fix: ClassFormatError when serializing classes with array-typed field…#4014
Open
fix: ClassFormatError when serializing classes with array-typed field…#4014
Conversation
…s, for issue #4009 When calling JSON.toJSON() on objects with Class[] or other array-typed fields, the ASM-based JIT code generator was creating class names like 'OWG_5_0_Class[]' which contain illegal characters for Java class names. Added sanitizeClassName() helper method to ObjectWriterCreatorASM and ObjectReaderCreatorASM to sanitize class simple names by converting array notation (e.g., 'Class[]' -> 'ClassArray') and replacing other invalid characters with underscores. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s, for issue #4009
When calling JSON.toJSON() on objects with Class[] or other array-typed fields, the ASM-based JIT code generator was creating class names like 'OWG_5_0_Class[]' which contain illegal characters for Java class names.
Added sanitizeClassName() helper method to ObjectWriterCreatorASM and ObjectReaderCreatorASM to sanitize class simple names by converting array notation (e.g., 'Class[]' -> 'ClassArray') and replacing other invalid characters with underscores.
What this PR does / why we need it?
Summary of your change
Please indicate you've done the following: